Ensure that supplied locale is normalized when creating an interactive table #1643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an interactive table, the locale value (supplied in the initial
gt()
call) is retrieved in order to display elements/controls in the language of the locale. However, there are a few ways to write a locale and internallynormalize_locale()
is used to standardize a provided locale to a chosen form.This wasn't done in the codepath for making an interactive table so using
"fr_CH"
instead of"fr-CH"
would have resulted in english text (the result of a failed lookup). This PR ensures that the locale value is normalized so the following code works as expected:Fixes: #1637